Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in getTokens() #1

Merged
merged 3 commits into from
Feb 20, 2024
Merged

changes in getTokens() #1

merged 3 commits into from
Feb 20, 2024

Conversation

Marielbamar21
Copy link
Contributor

Changes

An array was created with all the information of all the tokens and the getTokens() was modified to return the data from the new array.

Comment

please, to check.

An array was created with all the information of all the tokens and the getTokens() was modified to return the data from the new array.
@Marielbamar21 Marielbamar21 added the enhancement New feature or request label Feb 19, 2024
@0xslipk 0xslipk requested a review from rubenguc February 20, 2024 06:37
src/stealthex/stealhtex.interface.ts Outdated Show resolved Hide resolved
Comment on lines 54 to 60
// public async getTokens(): Promise<StealthExToken[]> {
// try {
// const { data } = await this.sendPetition<StealthExToken[]>('currency', 'get')

public async getTokens(): Promise<StealthExToken[]> {
try {
const { data } = await this.sendPetition<StealthExToken[]>('currency', 'get')

return data
} catch (err) {
this.logger.error({ err }, 'Error getting tokens.')
// return data
// } catch (err) {
// this.logger.error({ err }, 'Error getting tokens.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same!

Copy link
Contributor

@rubenguc rubenguc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@0xslipk 0xslipk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xslipk 0xslipk merged commit d9e8cdc into main Feb 20, 2024
1 check passed
@0xslipk 0xslipk deleted the develop branch February 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants